From 778e921440f0fa7f1b9b3dfa980806b61480940b Mon Sep 17 00:00:00 2001 From: Lawrence Lee Date: Wed, 14 Jun 2017 17:40:29 +0800 Subject: [PATCH 1/2] bugfix on transfer --- examples/routers/transfer.vue | 2 +- src/components/transfer/transfer.vue | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/examples/routers/transfer.vue b/examples/routers/transfer.vue index 570bb863..0e893388 100644 --- a/examples/routers/transfer.vue +++ b/examples/routers/transfer.vue @@ -164,7 +164,7 @@ export default { data () { return { - data1: this.getMockData(), + data1: [] || this.getMockData(), targetKeys1: this.getTargetKeys() } }, diff --git a/src/components/transfer/transfer.vue b/src/components/transfer/transfer.vue index b8df30f5..07691af5 100644 --- a/src/components/transfer/transfer.vue +++ b/src/components/transfer/transfer.vue @@ -194,14 +194,14 @@ this.rightData = []; if (this.targetKeys.length > 0) { this.targetKeys.forEach((targetKey) => { - this.rightData.push( - this.leftData.filter((data, index) => { - if (data.key === targetKey) { - this.leftData.splice(index, 1); - return true; - } - return false; - })[0]); + const filteredData = this.leftData.filter((data, index) => { + if (data.key === targetKey) { + this.leftData.splice(index, 1); + return true; + } + return false; + }) + if (filteredData && filteredData.length > 0) this.rightData.push(filteredData[0]) }); } if (init) { From 11748ba519226202d8d2272826906d1195838f2a Mon Sep 17 00:00:00 2001 From: Lawrence Lee Date: Wed, 14 Jun 2017 17:48:25 +0800 Subject: [PATCH 2/2] lint --- src/components/transfer/transfer.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/transfer/transfer.vue b/src/components/transfer/transfer.vue index 07691af5..2906f103 100644 --- a/src/components/transfer/transfer.vue +++ b/src/components/transfer/transfer.vue @@ -200,8 +200,8 @@ return true; } return false; - }) - if (filteredData && filteredData.length > 0) this.rightData.push(filteredData[0]) + }); + if (filteredData && filteredData.length > 0) this.rightData.push(filteredData[0]); }); } if (init) {