Merge pull request #2420 from SergioCrisostomo/input-number-fixes

fix checking when temp number is invalid
This commit is contained in:
Aresn 2017-11-15 20:45:13 -06:00 committed by GitHub
commit 82636f7ab8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -258,11 +258,15 @@
let val = event.target.value.trim(); let val = event.target.value.trim();
if (event.type == 'input' && val.match(/^\-?\.?$|\.$/)) return; // prevent fire early if decimal. If no more input the change event will fire later if (event.type == 'input' && val.match(/^\-?\.?$|\.$/)) return; // prevent fire early if decimal. If no more input the change event will fire later
if (event.type == 'change' && Number(val) === this.currentValue) return; // already fired change for input event
const {min, max} = this; const {min, max} = this;
const isEmptyString = val.length === 0; const isEmptyString = val.length === 0;
val = Number(val); val = Number(val);
if (event.type == 'change'){
if (val === this.currentValue && val > min && val < max) return; // already fired change for input event
}
if (!isNaN(val) && !isEmptyString) { if (!isNaN(val) && !isEmptyString) {
this.currentValue = val; this.currentValue = val;