From a74be22ea8d475a4fbf0aa35e38de74934dbd198 Mon Sep 17 00:00:00 2001 From: Sergio Crisostomo Date: Mon, 13 Nov 2017 16:57:43 +0100 Subject: [PATCH] don't check DOM tree past document.body --- src/components/tabs/tabs.vue | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/components/tabs/tabs.vue b/src/components/tabs/tabs.vue index 3332f955..71979901 100644 --- a/src/components/tabs/tabs.vue +++ b/src/components/tabs/tabs.vue @@ -239,8 +239,8 @@ if (!currentOffset) return; let newOffset = currentOffset > containerWidth - ? currentOffset - containerWidth - : 0; + ? currentOffset - containerWidth + : 0; this.setOffset(newOffset); }, @@ -251,16 +251,16 @@ if (navWidth - currentOffset <= containerWidth) return; let newOffset = navWidth - currentOffset > containerWidth * 2 - ? currentOffset + containerWidth - : (navWidth - containerWidth); + ? currentOffset + containerWidth + : (navWidth - containerWidth); this.setOffset(newOffset); }, getCurrentScrollOffset() { const { navStyle } = this; return navStyle.transform - ? Number(navStyle.transform.match(/translateX\(-(\d+(\.\d+)*)px\)/)[1]) - : 0; + ? Number(navStyle.transform.match(/translateX\(-(\d+(\.\d+)*)px\)/)[1]) + : 0; }, setOffset(value) { this.navStyle.transform = `translateX(-${value}px)`; @@ -313,7 +313,7 @@ }, isInsideHiddenElement () { let parentNode = this.$el.parentNode; - while(parentNode) { + while(parentNode && parentNode !== document.body) { if (parentNode.style.display === 'none') { return parentNode; }